revert: restore OTel exporter API compatibility#2256
Closed
zeitlinger wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
otel.instrumentation.versionfrom2.29.0-alphato2.28.1-alphadocs/apidiffs/current_vs_latest/prometheus-metrics-exporter-opentelemetry-shaded.txttoNo changes.Why
PR #2236 updated the shaded OpenTelemetry dependency and changed the public constructor type of
OpenTelemetryExporterin the shaded exporter module.That introduced a real
@StableApiincompatibility onmain:prometheus-metrics-exporter-opentelemetry-shaded: CONSTRUCTOR_REMOVEDBecause the compatibility gate compares every PR against the pinned release baseline, once that breaking change landed on
main, unrelated PRs started inheriting the sameapi-difffailure.mainshould not require per-PR acceptance labels for an already-merged patch/minor-line change, so this PR restores compatibility onmainby reverting the dependency bump.Validation
mise run lint:fixmise run api-diff(interrupted after the affected modules completed)prometheus-metrics-exporter-opentelemetry/target/japicmp/api-diff.diff→No changes.prometheus-metrics-exporter-opentelemetry-shaded/target/japicmp/api-diff.diff→No changes.