ci: detect api changes from committed diffs#2258
Open
zeitlinger wants to merge 1 commit into
Open
Conversation
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/apidiffs/current_vs_latest/the authoritative PR review artifact, matching the OpenTelemetry Java modelapi-changeand leaves a maintainer-review comment when those committed API diff files changeWhy
The previous label-based override only waived a single PR while CI still compared every future PR against the same released baseline. That meant one accepted breaking change kept poisoning unrelated follow-up PRs. The OTel Java pattern avoids that by reviewing and carrying forward the checked-in API diff files instead of keeping a second persistent incompatible-change gate.
Testing