[hardware] 🐛 Fix vrgather/vcompress + vmv.x.s MaskB deadlock#475
Open
emiliengnr wants to merge 1 commit into
Open
[hardware] 🐛 Fix vrgather/vcompress + vmv.x.s MaskB deadlock#475emiliengnr wants to merge 1 commit into
emiliengnr wants to merge 1 commit into
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, here is a pull request for a bug I found.
Problem
A
vrgather/vrgatherei16/vcompressimmediately followed by avmv.x.s(or
vfmv.f.s) that reads its result deadlocks the lane. Both instructions usethe per-lane ad-hoc MaskB operand channel. There is a brief window, before the
gather claims the channel (
masku_vrgat_req_valid_qstill low and the gatherFSM still
IDLE), in which theVFU_Nonepath accepts thevmv.x.s. The scalarmove takes MaskB and waits for the gather's result, while the gather waits for
the MaskB channel the move is holding. The lane never retires and the cva6 host
stalls on the accelerator handshake until reset.
Fix
Add a per-vinsn bitmap marking running
vrgather/vrgatherei16/vcompress(the ops that use the ad-hoc MaskB channel), and bar
VFU_Noneacceptance whileany such instruction is in flight in the lane. The scalar move then waits until
the gather has released the channel. Only the
VFU_Noneacceptance gate changes;other paths are untouched.
Changelog
Fixed
Checklist