fix: extend knmi importer with support for other projections - #562
Merged
Conversation
RubenImhoff
approved these changes
Jul 28, 2026
Contributor
|
Hi @mats-knmi, this is looking great! The tests still fail on the assertion of the right x- and y-grid coordinates. Is there still something wrong in the test grid (km instead of m), or is the assertion just too strict (with e-10)? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #562 +/- ##
==========================================
- Coverage 84.18% 84.13% -0.06%
==========================================
Files 170 170
Lines 14989 14992 +3
==========================================
- Hits 12618 12613 -5
- Misses 2371 2379 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of metadata is currently hardcoded in the importer. To allow files in knmi hdf5 format that have different values here, we need to extend the importer.