Skip to content

fix: extend knmi importer with support for other projections - #562

Merged
RubenImhoff merged 6 commits into
masterfrom
extend-knmi-importer
Jul 29, 2026
Merged

fix: extend knmi importer with support for other projections#562
RubenImhoff merged 6 commits into
masterfrom
extend-knmi-importer

Conversation

@mats-knmi

Copy link
Copy Markdown
Contributor

A lot of metadata is currently hardcoded in the importer. To allow files in knmi hdf5 format that have different values here, we need to extend the importer.

@mats-knmi
mats-knmi requested a review from RubenImhoff July 22, 2026 11:35
@RubenImhoff

Copy link
Copy Markdown
Contributor

Hi @mats-knmi, this is looking great! The tests still fail on the assertion of the right x- and y-grid coordinates. Is there still something wrong in the test grid (km instead of m), or is the assertion just too strict (with e-10)?

@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.67568% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.13%. Comparing base (0d569d6) to head (7b14d56).

Files with missing lines Patch % Lines
pysteps/io/importers.py 75.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #562      +/-   ##
==========================================
- Coverage   84.18%   84.13%   -0.06%     
==========================================
  Files         170      170              
  Lines       14989    14992       +3     
==========================================
- Hits        12618    12613       -5     
- Misses       2371     2379       +8     
Flag Coverage Δ
unit_tests 84.13% <75.67%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RubenImhoff
RubenImhoff merged commit 0fe0a47 into master Jul 29, 2026
8 of 10 checks passed
@RubenImhoff
RubenImhoff deleted the extend-knmi-importer branch July 29, 2026 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants