Fix issue with external ensemble nowcast for steps blending and no additional noise - #564
Open
mats-knmi wants to merge 8 commits into
Open
Fix issue with external ensemble nowcast for steps blending and no additional noise#564mats-knmi wants to merge 8 commits into
mats-knmi wants to merge 8 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #564 +/- ##
==========================================
+ Coverage 84.13% 84.64% +0.51%
==========================================
Files 170 170
Lines 14992 15095 +103
==========================================
+ Hits 12613 12777 +164
+ Misses 2379 2318 -61
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When providing the STEPS blending with an external nowcast that already contains its own noise, you can set the noise method to None. This, however, resulted in the weights not being computed correctly. This PR fixes this and also adds regression tests to make sure this does not happen again.
Additionally this PR updates the docstring to indicate better to users how we recommend this feature to be used.