Callable recipes - #308
Merged
Merged
Conversation
Let versions find them. Had trouble on my local machine with `tests.integration...` vs `integration...`. Signed-off-by: Liam Huber <liamhuber@greyhavensolutions.com>
This takes the quick-and-easy path of using a local import to the wfms module. Signed-off-by: Liam Huber <liamhuber@greyhavensolutions.com>
Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Liam Huber <liamhuber@greyhavensolutions.com>
Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Liam Huber <liamhuber@greyhavensolutions.com>
Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Liam Huber <liamhuber@greyhavensolutions.com>
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #308 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 44 44
Lines 3517 3569 +52
=======================================
+ Hits 3515 3567 +52
Misses 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
NodeRecipe.__call__an abstract method, and fulfills it in the outstanding flow controllers (and workflows without a reference) via local import to thewfms. At the same time, shores up errors that came from input incompleteness in the toywfms.Closes #307
After this, all
@workflow-decorated recipes stay callable, even when they invoke direct calls to recipe objects. This finalizes fulfillment of a promise that flowrep-decorated functions still work as plain functions.