Rename low-rank Choleksy factor (LRCF) to low-rank (LR) - #2574
Rename low-rank Choleksy factor (LRCF) to low-rank (LR) #2574ullmannsven wants to merge 7 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
468b897 to
c858323
Compare
pmli
left a comment
There was a problem hiding this comment.
Please also change appearances of "low-rank Cholesky factor" to "low-rank factor".
okay, I thought to leave this as it is in order to have additional descriptive value, but tbh i dont have an opinion on this and if its clear anyway that this is a Choleksy factor then i will remove it. Thanks for taking a look so fast! |
Well, that's the whole issue with "LRCF" to begin with, because |
Renaming LRCF to LR across all relevant places within pymor. The alternative would be to rename LRADI to LRCFADI, which is currently not the preferred option.
dummy PR in order to have it open before the soft freeze. I will work on this as soon as #2572 is merged.