Removed is_array_flag#20
Merged
Merged
Conversation
gupichon
approved these changes
Jun 5, 2026
gupichon
left a comment
gupichon
left a comment
Member
There was a problem hiding this comment.
There is an issue in the get_device method. A separate issue should be open. But it is separate from the current PR, so it's fine.
|
|
||
| if isinstance(ref, EpicsConfigR): | ||
| return self._attach([ref], ref.index is not None)[0] | ||
| return self._attach([ref])[0] |
Member
There was a problem hiding this comment.
There is an error, but it's not from this PR. The attach method expects a DeviceAccess, not a config model. An issue should be opened about this.
Member
Author
There was a problem hiding this comment.
attach() method expect DeviceAccess but they are deprecated and will be removed.
_attach() internal method well take ConfigModel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR remove the is_array flag.
It is OK for EPICS (tested on BESSY2 VA) however for Tango it requires this