Implemented BBA#314
Conversation
kparasch
left a comment
There was a problem hiding this comment.
I think it's great!
The only thing I don't like but could maybe get addressed in a future PR is that with this way, there is one BBA tuning tool per BPM.
|
Yes this is a simple implementation. |
|
From the example it seems that it only does a single quad-bpm pair. Is this correct? |
|
Yes no paralell BBA for the moment. |
|
Yes. For reference, the pySC BBA implemented here is the classic "model-independent" or "bow-tie" BBA algorithm adapted from MML. |
|
Like @kparasch pointed out, maybe at the end we will want only the parallel version in the configuration. Otherwise, we'll get a very long BBA config with only the names different. @kparasch Maybe there will be some contribution from SOLEIL to pySC with either fast BBA or fast ORM. To be checked (Sami will leave SOLEIL; maybe his replacement will be less inclined to only test the code). Or I'll do it because for SOLEIL II we do not plan to rely on the classic algorithm (takes too long). |
|
Yes here you can see the whole BBA config for EBS (using only pySC) To decrease this config size, a search of quad and steerer for a given bpm is needed. |
This PR implements BBA.
There is no most effective steerer detection and quad location detection yet. For the time being this has to be configured by hand.