Skip to content

Fix wrong BPM and adjusted delta #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JeanLucPons merged 2 commits into from
Jul 10, 2026
Merged

Fix wrong BPM and adjusted delta #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d3abfd
Fix wrong BPM and adjusted delta
JeanLucPons Jul 10, 2026
e662da2
Fix YP
JeanLucPons Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tests/config/EBSOrbit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,17 +37,17 @@ arrays:
- BPM*
devices:
- type: pyaml.tuning_tools.bba
name: BBA-BPM_C04-03
name: BBA-BPM_C04-04
bpm_array_name: BPM
bpm_name : BPM_C04-03
bpm_name : BPM_C04-04
hcorr_name : SF2E-C02-H
vcorr_name : SD1A-C26-V
quad_name : QF6B-C04
n_step: 7
hcorr_delta : 3.829380038425445e-05
vcorr_delta : 4.198292876029707e-05
hquad_delta : 0.005762885683993067
vquad_delta : 0.009329539724510462
hcorr_delta : 1e-05
vcorr_delta : 1e-05
hquad_delta : 0.005
vquad_delta : 0.005
- type: pyaml.diagnostics.tune_monitor
name: BETATRON_TUNE
tune_h: srdiag/beam-tune/main/Qh
Expand Down
2 changes: 1 addition & 1 deletion tests/test_yellow_pages_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
.

Tools:
BBA-BPM_C04-03 (pyaml.tuning_tools.bba)
BBA-BPM_C04-04 (pyaml.tuning_tools.bba)
CHROMATICITY_MONITOR (pyaml.tuning_tools.chromaticity_monitor)
DEFAULT_CHROMATICITY_RESPONSE_MATRIX (pyaml.tuning_tools.chromaticity_response_matrix)
DEFAULT_CHROMATICITY_CORRECTION (pyaml.tuning_tools.chromaticity)
Expand Down
8 changes: 4 additions & 4 deletions tests/tuning_tools/test_bba.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ def callback(action: int, data: dict):
def test_bba():
sr = Accelerator.load("tests/config/EBSOrbit.yaml")
SR = sr.design
bba = SR.get_bba("BBA-BPM_C04-03")
bba = SR.get_bba("BBA-BPM_C04-04")

# Add a misalignement
SR.get_bpm("BPM_C04-03").offset.set([20e-6, -15e-6])
SR.get_bpm("BPM_C04-04").offset.set([20e-6, -15e-6])
# Measure offsets
bba.measure()
assert np.abs(bba.h_offset() - 20e-6) < 2e-6
assert np.abs(bba.v_offset() + 15e-6) < 2e-6
assert np.abs(bba.h_offset() - 20e-6) < 1e-6
assert np.abs(bba.v_offset() + 15e-6) < 1e-6
Loading