Skip to content

Accept lowercase IBANs in iban() #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sayantanmandal1 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Accept lowercase IBANs in iban() #471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/validators/iban.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@


def _char_value(char: str):
"""A=10, B=11, ..., Z=35."""
return char if char.isdigit() else str(10 + ord(char) - ord("A"))
"""A=10, B=11, ..., Z=35 (case-insensitive)."""
return char if char.isdigit() else str(10 + ord(char.upper()) - ord("A"))


def _mod_check(value: str):
Expand Down
6 changes: 6 additions & 0 deletions tests/test_iban.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,12 @@ def test_returns_true_on_valid_iban(value: str):
assert iban(value)


@pytest.mark.parametrize("value", ["gb82west12345698765432", "No9386011117947"])
def test_returns_true_on_valid_lowercase_iban(value: str):
"""Lowercase/mixed-case IBANs are accepted (the format regex is case-insensitive)."""
assert iban(value)


@pytest.mark.parametrize("value", ["GB81WEST12345698765432", "NO9186011117947"])
def test_returns_failed_validation_on_invalid_iban(value: str):
"""Test returns failed validation on invalid iban."""
Expand Down