gh-95555: Allow a negated property as a character set member#152245
Merged
serhiy-storchaka merged 1 commit intoJun 26, 2026
Conversation
A negated multi-range property such as \P{ASCII} or \P{Pattern_Syntax} was
rejected inside a character class. Such members are now alternated in with
the other members: [\P{ASCII}abc] becomes [abc] | [^ASCII], and [\P{ASCII}]
alone is just the negated charset.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to gh-95555 (#151969).
A negated multi-range property such as
\P{ASCII}or\P{Pattern_Syntax}was rejected inside a character class. Such a property compiles to a complemented charset, so it could not simply be flattened into the member union. It is now set aside and alternated in with the other members:[\P{ASCII}]alone is just the negated charset;[\P{ASCII}abc]becomes[abc] | [^ASCII].Leading
^(De Morgan) and double negation ([^\P{ASCII}]= ASCII) are handled by the existing set-complement code, and it composes with the set operations:[\w--\P{ASCII}]is the ASCII word characters.Category-backed
\P{...}(e.g.\P{Lu},\P{digit}), which is a singleCATEGORYopcode, always composed fine; only the multi-range properties were affected.No news entry:
\p{...}is unreleased (.. versionadded:: next), so the lifted restriction never shipped.reshould support\p{...}character properties #95555