[3.13] gh-155411: Fix test.support.subTests() for asynchronous tests (GH-155412) - #155546
Merged
serhiy-storchaka merged 4 commits intoAug 12, 2026
Merged
Conversation
…ythonGH-155412) An asynchronous test was wrapped in a synchronous function, which discarded the coroutine without awaiting it, so the test did not run at all and was reported as successful. (cherry picked from commit 198a835) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
|
||
| # A synchronous wrapper would discard the coroutine without awaiting | ||
| # it, so an asynchronous test would not run at all. | ||
| if inspect.iscoroutinefunction(func): |
Member
There was a problem hiding this comment.
You'll have to add an inspect import I think @serhiy-storchaka
StanFromIreland
disabled auto-merge
August 12, 2026 10:33
It is not imported at module level in 3.13.
serhiy-storchaka
enabled auto-merge (squash)
August 12, 2026 13:32
serhiy-storchaka
disabled auto-merge
August 12, 2026 13:43
Running an event loop sets it, and regrtest reports it as a change of the environment when the tests run in a single process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An asynchronous test was wrapped in a synchronous function, which
discarded the coroutine without awaiting it, so the test did not run at
all and was reported as successful.
(cherry picked from commit 198a835)
Co-authored-by: Serhiy Storchaka storchaka@gmail.com