gh-61366: Write session cookies in the curl and Wget format - #155602
Open
serhiy-storchaka wants to merge 9 commits into
Open
gh-61366: Write session cookies in the curl and Wget format#155602serhiy-storchaka wants to merge 9 commits into
serhiy-storchaka wants to merge 9 commits into
Conversation
test.support.TESTFN and MozillaCookieJar.header no longer exist.
…-session-cookies-in-MozillaCookieJar
Writing 0 instead of an empty field makes the file incompatible with unpatched Python, so it is left for a separate change.
curl and Wget ignore the line if this field is empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session cookies are now saved with
0in the expiration time field, as curl and Wget do. Previously this field was left empty, and such lines are ignored by curl and Wget, so all session cookies were lost.This is based on #11792, which adds reading such files, and should be merged after it. Unlike it, this change is not backported, because files written with
0are not read by unpatched Python.