Fix symlinked standard-library path detection - #21838
Draft
aryansk wants to merge 1 commit into
Draft
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21474.
sysconfig.get_path("stdlib")can return a symlinked path while Python exposes the resolved target insys.path, as with Homebrew installations.getsyspath()now compares real paths when excluding the host standard library, while preserving the absolute path spelling returned for non-standard-library entries. Added a regression test covering the symlinked layout.Testing:
uv run --no-project --python 3.13 --with pytest --with mypy-extensions --with typing_extensions --with pathspec --with librt --with ast-serialize python -m pytest -q -o addopts="" mypy/test/testpyinfo.pyuv run --no-project --python 3.13 --with pre-commit pre-commit run --files mypy/pyinfo.py mypy/test/testpyinfo.pyPrepared with AI assistance; maintainer review is requested.