Make typing_extensions.TypedDict a distinct symbol to typing.TypedDict#15943
Merged
Conversation
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Member
Author
|
The full mypy test suite appears to pass with these changes applied. I'm checking the impact this would have on pyright users in AlexWaygood/pyright#2, a PR to my fork of pyright |
Member
Author
|
The pyright ecosystem check is clean: AlexWaygood/pyright#2 (comment). @rchen152, would this change cause any problems for pyrefly? |
JelleZijlstra
approved these changes
Jun 25, 2026
Collaborator
Doesn't seem to cause any problems. I pointed pyrefly at a copy of typeshed with this change, and it still recognizes typing_extensions.TypedDict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would allow ty to remove some hacks...