ci: build all Quasar projects when .ghaignore is empty#87
Merged
Conversation
quasar.yml computed its project list with `find ... | grep -vE "$ignore_pattern"`. With .ghaignore empty, ignore_pattern is empty and `grep -vE ""` matches every line, so the inverted match dropped every project and the workflow passed without building anything. Guard the filter so it only runs when a pattern exists, matching anchor.yml, native.yml, pinocchio.yml and solana-asm.yml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
quasar.ymlhad the same latent bug fixed inanchor.ymlduring the Anchor 1.1.2 upgrade (#84): it computed its project list withfind … | grep -vE "$ignore_pattern". Now that.ghaignoreis empty,ignore_patternis empty andgrep -vE ""matches every line, so the inverted match drops all projects — the build matrix is empty and the workflow reports success without building or testing anything.This guards the filter so it only runs when a pattern actually exists, matching the fix already present in
anchor.yml,native.yml,pinocchio.yml, andsolana-asm.yml. All five framework workflows are now consistent.Changes
.github/workflows/quasar.yml: only apply the.ghaignorefilter whenignore_patternis non-empty; otherwise list allquasarproject directories.🤖 Generated with Claude Code
Generated by Claude Code