Preserve all story images when saving the images form - #252
Merged
Conversation
The images form renders a field for every existing image, but saving only recreated images 1-3, silently dropping any additional images. Iterate over all rendered image fields instead of a hardcoded range.
Instead of deleting and recreating all images on every save, keep unchanged images as they are, remove only cleared or replaced ones, and create new rows just for new uploads. This preserves each image's name and audit fields, and stops the form from resurrecting soft deleted images, which are now also excluded from the form.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The story images form renders a field for every existing image, but on save it deleted all of the story's images and recreated only the first three — a story with four or more images (e.g. created via the API or shell) silently lost the rest when an editor saved the page.
The save handler now iterates over every rendered image field, so nothing that was displayed is dropped; clearing a field still removes that image. Includes a regression test with a 4-image story.