Send invitation emails via async task and use crypto-safe secrets - #254
Merged
Conversation
Dispatch the invitation email celery task with .delay() after the transaction commits instead of running it synchronously in the request, make the task a no-op if the invitation no longer exists, and generate invitation secrets with the secrets module instead of random.
…ypto-safe random for secrets and check uniqueness with exists()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invitation.send_invitation()invoked the celery task function directly, running the email send synchronously inside the web request — an SMTP outage could 500 the accounts management view partway through updating org membership. Invitation secrets were also generated with the non-cryptographicrandommodule despite gating account creation.The email task is now dispatched with
.delay()insidetransaction.on_commit(so a worker can't race the uncommitted row), the task no-ops gracefully if the invitation has been deleted, and secrets usesecrets.choice. Test settings enable celery eager mode so the email assertions exercise the async path.