Fix Org.build_host_link null subdomain, https for custom domains, hostname typo - #259
Merged
Conversation
… custom domains on secure deployments, fix hostname fallback typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Org.build_host_link()only handled a blank subdomain, so an org with a NULL subdomain produced links likehttp://None.example.com— which flow into invitation emails. The custom-domain branch also always returnedhttp://even on secure deployments (the subdomain branch already switched onSESSION_COOKIE_SECURE), and the hostname fallback had a typo ("locahost").A None subdomain is now treated like blank, the scheme is computed once and applied to both branches, and the typo is fixed. Tests cover the None-subdomain and secure/insecure custom-domain cases.
Note that the custom-domain scheme change is an intentional reversal of earlier behavior that deliberately served custom-domain links over
http(since custom domains might not have TLS configured). Custom-domain links now usehttpswhenever the deployment signals secure cookies viaSESSION_COOKIE_SECURE. Operators running a custom domain without TLS termination should not enableSESSION_COOKIE_SECURE, or should set up TLS for their custom domains before upgrading.