Fix dashblock teaser and str with NULL fields, whole-tag filtering and image upload path - #262
Open
norkans7 wants to merge 3 commits into
Open
Fix dashblock teaser and str with NULL fields, whole-tag filtering and image upload path#262norkans7 wants to merge 3 commits into
norkans7 wants to merge 3 commits into
Conversation
…d image upload path
Tag normalization (lowercase, collapsed whitespace, space padding) now happens in DashBlock.save() so blocks created outside the edit views also match whole-tag filtering. A data migration normalizes existing rows, and the load_dashblocks tag treats an empty or None tag as no filtering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several dashblock fixes: teaser methods crashed with AttributeError when the underlying field was NULL (legitimately the case when the block type disables it) and appended a truncation suffix even when nothing was truncated;
__str__returned None for a titled type with a NULL title; theload_dashblockstemplate tag filtered tags with a bare substring match, contradicting the padded space-delimited storage format (loading "art" also matched "smart"); and the image upload path had a trailing slash producing double-slash paths.Teasers now return an empty string for NULL fields and only append the suffix when truncating,
__str__falls back to the type name and pk, tag filtering matches whole padded tags, and the upload folder is normalized (with a migration for theupload_tochange). All covered by tests.