brcmfmac: PMKID needs to be passed to firmware if present#7455
Merged
Conversation
bnicolae
changed the title
Contributor
|
What a neat little patch. If you write a sentence or two on what it does and give me a |
External authentication during WPA3 SAE exchange ignores the PMKID and passes garbage (whatever is on the stack) downstream. This causes latent bugs (bogus entries in the firmware's lookup tables) that lead to connectivity issues. For example, in AP mode, a client that includes a PMKID in association frames will be rejected. The fix sets the PMKID either to zeros or the correct value if present, ensuring no bogus entries are used downstream. Signed-off-by: Bogdan Nicolae (bogdan.nicolae@acm.org)
Contributor
|
@bnicolae Could you please send this patch upstream? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix to issue #7359. The brcmfmac driver simply ignored PMKID instead of correctly passing it to firmware. Also, zero out pmkid (to avoid leaking from the stack garbage, which may confuse the firmware).