Fix api test app in CI#84
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the api-test-app used in CI so it can run deterministically in non-interactive environments and report failures via a non-zero exit code.
Changes:
- Added per-demo failure tracking so API call errors can be aggregated.
- Updated
--autoexecution to iterate all interfaces/methods, then exit1if any method returned an error. - Reordered runtime-mode selection so
--autotakes precedence even when stdin is non-TTY (common in CI).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
test/api_test_app/utils.h |
Track method failures in DemoBase::succeed() and expose failureCount() for aggregation. |
test/api_test_app/main.cpp |
Make --auto mode run in CI (even with non-TTY stdin) and fail the process when errors occurred. |
brendanobra
reviewed
Jun 29, 2026
brendanobra
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.