Skip to content

RDKEMW-17486 : Add dolbyAtmosExperienceAvailable getter and event sub…#86

Open
swethasukumarr wants to merge 2 commits into
developfrom
feature/RDKEMW-17486
Open

RDKEMW-17486 : Add dolbyAtmosExperienceAvailable getter and event sub…#86
swethasukumarr wants to merge 2 commits into
developfrom
feature/RDKEMW-17486

Conversation

@swethasukumarr

Copy link
Copy Markdown
Contributor

…scription

Copilot AI review requested due to automatic review settings June 30, 2026 11:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Device API surface for querying and subscribing to Dolby Atmos experience availability, and wires it through implementation and OpenRPC fixtures so unit/component tests and the demo app can exercise it.

Changes:

  • Added Device.dolbyAtmosExperienceAvailable getter to the public IDevice interface and DeviceImpl.
  • Added Device.onDolbyAtmosExperienceAvailableChanged subscription API to IDevice/DeviceImpl plus unit/component coverage.
  • Updated OpenRPC spec fixtures (current + legacy + app notifier) and the API demo app to include the new method.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
include/firebolt/device.h Extends the public IDevice interface with the new getter and subscription API.
src/device_impl.h Declares the new DeviceImpl overrides for the added IDevice methods.
src/device_impl.cpp Implements the getter via helper_.get<Boolean> and the event subscription via subscriptionManager_.
test/unit/deviceTest.cpp Adds unit tests for success/bad-response paths for the getter and a subscription smoke test.
test/component/deviceTest.cpp Adds component tests for the getter and end-to-end event subscription + event trigger flow.
test/api_test_app/apis/deviceDemo.cpp Exposes the new getter in the demo app’s method list and output.
docs/openrpc/the-spec/firebolt-open-rpc.json Adds the new getter method and event subscription definition with examples/tags.
docs/openrpc/the-spec/firebolt-open-rpc--legacy.json Mirrors the getter + subscriber definitions in the legacy OpenRPC fixture.
docs/openrpc/the-spec/firebolt-app-open-rpc.json Adds the app-side notifier definition for the new Device event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants