chore: standardize repository config#1072
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
❌ Deploy failed
📋 Build log (last lines)🤖 Powered by surge-preview |
|||||||||
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
Walkthrough更新了文档站点构建与部署路径，重写 README 和文档内容，并调整了 GitHub Actions、Dependabot、Funding 和 Vercel 配置。 Changes文档站点与仓库自动化更新
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested reviewers
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1072 +/- ##
=======================================
Coverage 98.67% 98.67%
=======================================
Files 15 15
Lines 752 752
Branches 234 234
=======================================
Hits 742 742
Misses 10 10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the repository configuration, build scripts, and documentation for @rc-component/slider. Key changes include migrating documentation build paths to docs-dist, adding Vercel deployment configurations, updating TypeScript compiler options, and modernizing the README.md with updated API tables and examples. The review feedback focuses on improving cross-platform compatibility in package.json by using cross-env and fixing markdown formatting issues in the README.md API tables.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (1)
.github/workflows/codeql.yml (1)
26-43: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value建议在固定哈希后附带版本注释，便于维护。
将 action 固定到提交哈希是良好的安全实践。但裸哈希难以辨识对应版本，建议在每个引用后追加版本注释（例如
# v3.x.x），方便后续审计与升级。♻️ 示例
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 + uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v4.x.x🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/codeql.yml around lines 26 - 43, The GitHub Actions references are pinned to commit SHAs, but the entries in the workflow are missing version comments, making maintenance and audits harder. Update the existing action references in the codeQL workflow, especially the Checkout, Initialize CodeQL, Autobuild, and Perform CodeQL Analysis steps, to include a brief version annotation after each fixed hash so the pinned release can be identified later without changing the security posture.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/react-component-ci.yml:
- Around line 7-8: The reusable workflow call is using a mutable ref and
inheriting all secrets, so update the workflow invocation to pin
react-component/rc-test/.github/workflows/test-utoo.yml to an immutable commit
SHA or tag instead of `@main`, and replace secrets: inherit with an explicit
secrets mapping that passes only the required credentials. Keep the fix in the
workflow job that calls the external workflow so the reference remains stable
and the secret surface is minimized.
In `@README.md`:
- Around line 68-69: The type description for ariaValueTextFormatterForHandle is
malformed because “Array function” is not a valid TypeScript type annotation.
Update the README entry for ariaValueTextFormatterForHandle so the type is
expressed consistently using a valid function signature, matching the intended
array-of-functions form referenced in the comment, and ensure the table text
clearly distinguishes a single formatter from an array of formatter functions.
- Around line 74-76: The README table entry for `dots` is inaccurate and implies
it only shows dots when `step` is greater than 1; update the description to
reflect the actual behavior of the `dots` prop. In the documentation table near
`disabled`, `dots`, and `dotStyle`, revise the `dots` text to say it shows dots
at each valid step position, keeping the wording aligned with how the prop is
used in the component API.
In `@tsconfig.json`:
- Around line 16-17: TypeScript 目前只解析了 `@rc-component/slider` 根入口，但文档示例还直接导入了
`@rc-component/slider/assets/index.css`，导致 `tsc --noEmit` 在检查 `docs/examples`
时找不到模块。请在 `tsconfig.json` 的 `paths` 中同步补齐 `@rc-component/slider/assets/*`
的映射，并确保它指向实际的 assets 物理路径；同时确认 `typings.d.ts` 里的 `declare module '*.css'`
仍然生效，以便 `README` 示例和 `docs/examples` 中的 CSS 导入都能通过类型检查。
---
Nitpick comments:
In @.github/workflows/codeql.yml:
- Around line 26-43: The GitHub Actions references are pinned to commit SHAs,
but the entries in the workflow are missing version comments, making maintenance
and audits harder. Update the existing action references in the codeQL workflow,
especially the Checkout, Initialize CodeQL, Autobuild, and Perform CodeQL
Analysis steps, to include a brief version annotation after each fixed hash so
the pinned release can be identified later without changing the security
posture.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 32e55e93-8b36-460e-be99-08905e91adea
📒 Files selected for processing (16)
.dumirc.ts.github/FUNDING.yml.github/dependabot.yml.github/workflows/codeql.yml.github/workflows/main.yml.github/workflows/react-component-ci.yml.github/workflows/react-doctor.yml.github/workflows/surge-preview.yml.gitignoreREADME.mddocs/examples/slider.tsxdocs/index.mdnow.jsonpackage.jsontsconfig.jsonvercel.json
💤 Files with no reviewable changes (3)
- .github/workflows/main.yml
- docs/examples/slider.tsx
- now.json
|
Deployment failed with the following error: Learn More: https://vercel.com/react-component?upgradeToPro=build-rate-limit |
|
Deployment failed with the following error: Learn More: https://vercel.com/afc163s-projects?upgradeToPro=build-rate-limit |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
1 participant
Summary
Standardize this rc-component repository as part of the Ant Design rc-component maintenance sweep.
Tracking issue: ant-design/ant-design#58514
Scope
types: "./es/index.d.ts", publishConfig, and release flow through@rc-component/np.react-component/rc-test/.github/workflows/test-utoo.yml@mainworkflow, React Doctor, Codecov, CodeQL, updated GitHub Actions versions, and guarded Surge preview fallback.docs-distoutput and remove legacynow-build/ Cloudflare Pages residue.Notes
secrets: inheritis kept untilreact-component/rc-test#176is merged, then it can be narrowed to explicitCODECOV_TOKENforwarding.