fix(harmony): widen rnoh dependency range to support both 0.72 and 0.77+#596
Conversation
📝 WalkthroughWalkthroughThe dependency version constraint for ChangesDependency Constraint Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
harmony/pushy/oh-package.json5 (1)
12-12: 🩺 Stability & Availability | 🔵 Trivial | ⚖️ Poor tradeoffUnbounded upper bound risks pulling in future breaking versions.
The
>=0.72.96constraint removes all upper bounds, allowing any future major or minor version (e.g.,1.0.1,2.3.4) that may introduce breaking changes. For a published library, this can cause downstream resolution failures or runtime incompatibilities when new versions are released.Consider constraining to tested compatible versions, e.g.,
>=0.72.96 <0.80.0or^0.72.96 || ^0.77.1, depending on your compatibility matrix. If you intentionally want broad compatibility, verify that@rnoh/react-native-openharmonyfollows semver and that breaking changes are reserved for major versions.- '`@rnoh/react-native-openharmony`': '>=0.72.96', + '`@rnoh/react-native-openharmony`': '>=0.72.96 <1.0.0',Or, if 0.77 is the only additional tested version:
- '`@rnoh/react-native-openharmony`': '>=0.72.96', + '`@rnoh/react-native-openharmony`': '^0.72.96 || ^0.77.1',🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@harmony/pushy/oh-package.json5` at line 12, The dependency range for `@rnoh/react-native-openharmony` is unbounded and can pull in future breaking releases. Update the version constraint in oh-package.json5 to a tested upper-bounded range (for example, a compatible window like >=0.72.96 <0.80.0 or an explicit union of tested ranges) so published consumers don’t resolve to incompatible versions.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@harmony/pushy/oh-package.json5`:
- Line 12: The dependency range for `@rnoh/react-native-openharmony` is unbounded
and can pull in future breaking releases. Update the version constraint in
oh-package.json5 to a tested upper-bounded range (for example, a compatible
window like >=0.72.96 <0.80.0 or an explicit union of tested ranges) so
published consumers don’t resolve to incompatible versions.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 7ac59cb0-decf-477b-9554-4b96006fc2ec
📒 Files selected for processing (1)
harmony/pushy/oh-package.json5
This PR updates
oh-package.json5dependency for@rnoh/react-native-openharmonyfrom^0.72.96to>=0.72.96to allow users of React Native OpenHarmony 0.77+ to install the library without peer dependency conflicts.Summary by CodeRabbit