feat(core): export FetchError as a named export from @readme/api-core#1180
Merged
erunion merged 1 commit intoJul 6, 2026
Merged
Conversation
FetchError could only be imported via the @readme/api-core/errors/fetchError subpath even though it's thrown directly by APICore#fetch, so consumers had no discoverable way to import it for instanceof checks alongside the main APICore import. Signed-off-by: Zain Asif <zainasif.jutt1@gmail.com>
🦋 Changeset detectedLatest commit: c492666 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
erunion
changed the title
FetchError as a named export from @readme/api-core
erunion
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FetchErroris thrown directly byAPICore#fetchfor error-level status codes, but it could only be imported via the@readme/api-core/errors/fetchErrorsubpath. There was no way to import it alongside the mainAPICoreimport from the package root, making it harder for consumers to discover how to doinstanceofchecks against it.This adds a named export for
FetchErrorfrom the package root (packages/core/src/index.ts), so it can now be imported as:in addition to the existing subpath import.
Fixes #967
Testing
Added a test asserting that the named export from the package root is the exact same class as the one imported from the
errors/fetchErrorsubpath. Ran the full@readme/api-coretest suite (83 passing) andtsc --noEmit, both clean.