Skip to content

docs: fix grammar and spelling mistakes#4413

Open
JojocraftTv wants to merge 2 commits into
redhat-developer:mainfrom
JojocraftTv:main
Open

docs: fix grammar and spelling mistakes#4413
JojocraftTv wants to merge 2 commits into
redhat-developer:mainfrom
JojocraftTv:main

Conversation

@JojocraftTv

Copy link
Copy Markdown

Changes

  • Fixed a few spelling and grammar mistakes I noticed while reading.
  • Fixed the default Project JDKs example, which contained invalid JSON.

@wenytang-ms wenytang-ms left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JojocraftTv Nice cleanup, the grammar and spelling fixes all look good to me. The colon spacing in the settings list is a nice touch too.

One thing though, the JSON example still isn't quite valid. The runtimes block at the top of the Project JDKs section still has trailing commas on the first two entries:

  {
    "name": "JavaSE-1.8",
    "path": "/path/to/jdk-8",
  },
  {
    "name": "JavaSE-11",
    "path": "/path/to/jdk-11",
  },

Those commas after the last property make it invalid JSON, so they should go:

  {
    "name": "JavaSE-1.8",
    "path": "/path/to/jdk-8"
  },
  {
    "name": "JavaSE-11",
    "path": "/path/to/jdk-11"
  },

Drop those two and the whole snippet is valid. Otherwise this is good to go.

@wenytang-ms wenytang-ms left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, the grammar and spelling fixes all look good to me. The colon spacing in the settings list is a nice touch too.

One thing though, the JSON example still isn't quite valid. The runtimes block at the top of the Project JDKs section still has trailing commas on the first two entries:

  {
    "name": "JavaSE-1.8",
    "path": "/path/to/jdk-8",
  },
  {
    "name": "JavaSE-11",
    "path": "/path/to/jdk-11",
  },

Those commas after the last property make it invalid JSON, so they should go:

  {
    "name": "JavaSE-1.8",
    "path": "/path/to/jdk-8"
  },
  {
    "name": "JavaSE-11",
    "path": "/path/to/jdk-11"
  },

Drop those two and the whole snippet is valid. Otherwise this is good to go.

@JojocraftTv

Copy link
Copy Markdown
Author

Thanks for pointing that out ^^
Fixed it. That must have slipped through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants