docs: fix grammar and spelling mistakes#4413
Conversation
There was a problem hiding this comment.
@JojocraftTv Nice cleanup, the grammar and spelling fixes all look good to me. The colon spacing in the settings list is a nice touch too.
One thing though, the JSON example still isn't quite valid. The runtimes block at the top of the Project JDKs section still has trailing commas on the first two entries:
{
"name": "JavaSE-1.8",
"path": "/path/to/jdk-8",
},
{
"name": "JavaSE-11",
"path": "/path/to/jdk-11",
},Those commas after the last property make it invalid JSON, so they should go:
{
"name": "JavaSE-1.8",
"path": "/path/to/jdk-8"
},
{
"name": "JavaSE-11",
"path": "/path/to/jdk-11"
},Drop those two and the whole snippet is valid. Otherwise this is good to go.
wenytang-ms
left a comment
There was a problem hiding this comment.
Nice cleanup, the grammar and spelling fixes all look good to me. The colon spacing in the settings list is a nice touch too.
One thing though, the JSON example still isn't quite valid. The runtimes block at the top of the Project JDKs section still has trailing commas on the first two entries:
{
"name": "JavaSE-1.8",
"path": "/path/to/jdk-8",
},
{
"name": "JavaSE-11",
"path": "/path/to/jdk-11",
},Those commas after the last property make it invalid JSON, so they should go:
{
"name": "JavaSE-1.8",
"path": "/path/to/jdk-8"
},
{
"name": "JavaSE-11",
"path": "/path/to/jdk-11"
},Drop those two and the whole snippet is valid. Otherwise this is good to go.
|
Thanks for pointing that out ^^ |
Changes