fix: flac loses its tail at finalize (#497) - #499
Open
remsky wants to merge 2 commits into
Open
Conversation
Owner
Author
* Opus bytes differ only in the random Ogg serial number stamped per writer; decoded output is identical. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Output buffer is truncated after every chunk, so muxers that seek back to
patch a header at pos 0 on close (wav RIFF sizes, flac STREAMINFO, mp3 xing) were landing the patch on the flushed audio instead.
Finalize now reads before close for everything except ogg, which appends its last audio page during close. Drops the wav
return b""special case from #463, no longer needed with the correct order.spec-valid); libsndfile readers reject it, same as before this fix. ffmpeg/pyav decode fully.
Diagnosis by @Technologicat in #497.