Skip to content

feat(completion): explicit completion-date control menu #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renatomen wants to merge 10 commits into
base: feat/completion-occurrence-context-skip-fix
Choose a base branch
from
Open

feat(completion): explicit completion-date control menu #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a73781c
feat(completion): add four-mode completion-date resolver
renatomen Jul 4, 2026
e46e7e3
feat(completion): thread optional completion date through status pipe…
renatomen Jul 4, 2026
8bc4f13
feat(completion): explicit completion menu actions with date control
renatomen Jul 4, 2026
1cf16b8
fix(review): neutral completion failure notice + close coverage gaps
renatomen Jul 4, 2026
031ebcc
test: pin Jest timezone to UTC to match CI
renatomen Jul 4, 2026
4a838a8
feat(completion): nest actions in a submenu, uniform labels, reschedu…
renatomen Jul 4, 2026
8c3864e
refine(completion): rename submenu to 'Mark complete or skip'; resche…
renatomen Jul 4, 2026
ee44ffe
feat(completion): confirm before a reschedule clears recorded instances
renatomen Jul 4, 2026
7365a86
feat(settings): toggle complete/skip actions between submenu and flat…
renatomen Jul 4, 2026
e925c9d
feat(completion): add dividers around the flat complete/skip block
renatomen Jul 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions i18n.manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,6 +811,8 @@
"settings.appearance.taskCards.description": "4554f6f0816fa0c30fb2d11d11b7a4e0e9a610de",
"settings.appearance.taskCards.defaultVisibleProperties.name": "0aa5efd8c0508868b5a726a4f3890fc3efb71d26",
"settings.appearance.taskCards.defaultVisibleProperties.description": "1673317e8fda5fc944e0458b5e51563c048e2dcd",
"settings.appearance.taskCards.completionSubmenu.name": "599d4040155ef8e0e7e6c70cdd3cb24583b2302f",
"settings.appearance.taskCards.completionSubmenu.description": "edc8f49c252f25483a01c4675be3e296ba2623c9",
"settings.appearance.taskCards.propertyGroups.coreProperties": "acae0b9efe790c7be9c7a70dd1db4826a9eef7f7",
"settings.appearance.taskCards.propertyGroups.organization": "9da72239ddeee345a6b025c468d9817c49cae014",
"settings.appearance.taskCards.propertyGroups.customProperties": "07daf13a314add9a92c0f8e5564d81ce72e4937c",
Expand Down Expand Up @@ -1841,6 +1843,22 @@
"contextMenus.task.markIncomplete": "8d0d3b84c6c7d795e205c345054f9335ae222c21",
"contextMenus.task.skipInstance": "ebb18d68bb33bb3188ca558e22656fa8f4cb7e95",
"contextMenus.task.unskipInstance": "f58b99fdb842bddf12fa964f933eb1d9bd54843e",
"contextMenus.task.completion.submenu": "54a51295b3ea49320049e2c7a225326711e0a571",
"contextMenus.task.completion.submenuCompleteOnly": "0c018491b96aadfff5ebeb45434a2945bdd12741",
"contextMenus.task.completion.completeToday": "f86a2e78fa25078c77c8b36a58c7adabfdc0b725",
"contextMenus.task.completion.completeAsScheduled": "5816ce12a13d6c586d600d2a38ca8fd669bfac38",
"contextMenus.task.completion.completeOnDue": "d915b497e5849ebf0a27d1ed54173a355fe96232",
"contextMenus.task.completion.completeOnPicked": "9c2baea91e78091a5c390492c920218cc2a66146",
"contextMenus.task.completion.markIncomplete": "3ae756e7c4063158572bde2513eeebd18a7ffb62",
"contextMenus.task.completion.noScheduledDate": "b26b6e02e0a284a7ae4d1326db014438a8d8f860",
"contextMenus.task.completion.noDueDate": "7fd1fe06f971d95e436f7ee5b7c3ce4390e66ddb",
"contextMenus.task.completion.noPickedDate": "d4ee6469f6d100f64fd1e5f328c800c1ee3f2788",
"contextMenus.task.completion.noCompletedStatus": "17a5c4be21c3ae7b7320d3ee28ca1cb611221530",
"contextMenus.task.completion.pickDateTitle": "b7bb83924b90b81af703aedc3bb16bdc4c239ec5",
"contextMenus.task.completion.completeFailure": "2bd697dbae7139872c337782e64b31b0f78b4a25",
"contextMenus.task.completion.clearInstancesConfirmTitle": "a819ff5087a10bfd7d0300249ce038f90e818702",
"contextMenus.task.completion.clearInstancesConfirmMessage": "2220d4a9ab7e1b7f1224c48a64a310d0ea2caecc",
"contextMenus.task.completion.clearInstancesConfirmButton": "3bdcd7189cfa14996da1fdf37761df828a182d7e",
"contextMenus.task.quickReminders.atTime": "87270e0d6c46f3d0c3510c6c2a2f1e31e8b0ab60",
"contextMenus.task.quickReminders.fiveMinutes": "c777f20872b577e3164c1b6d3f4f50d70faa8e93",
"contextMenus.task.quickReminders.fifteenMinutes": "4bba5a72574fef683d773d45198acbf9a56d8961",
Expand Down
144 changes: 144 additions & 0 deletions i18n.state.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3248,6 +3248,8 @@
"source": "1673317e8fda5fc944e0458b5e51563c048e2dcd",
"translation": "6dcf0eab268427f03a4e65a6caa6da86bf7b388b"
},
"settings.appearance.taskCards.completionSubmenu.name": null,
"settings.appearance.taskCards.completionSubmenu.description": null,
"settings.appearance.taskCards.propertyGroups.coreProperties": {
"source": "acae0b9efe790c7be9c7a70dd1db4826a9eef7f7",
"translation": "8b854e53ad33addbdd700ee4851887dbc68b254c"
Expand Down Expand Up @@ -7368,6 +7370,22 @@
"source": "f58b99fdb842bddf12fa964f933eb1d9bd54843e",
"translation": "dc50f18bbaa3249131904a53adc71400e7ebcd31"
},
"contextMenus.task.completion.submenu": null,
"contextMenus.task.completion.submenuCompleteOnly": null,
"contextMenus.task.completion.completeToday": null,
"contextMenus.task.completion.completeAsScheduled": null,
"contextMenus.task.completion.completeOnDue": null,
"contextMenus.task.completion.completeOnPicked": null,
"contextMenus.task.completion.markIncomplete": null,
"contextMenus.task.completion.noScheduledDate": null,
"contextMenus.task.completion.noDueDate": null,
"contextMenus.task.completion.noPickedDate": null,
"contextMenus.task.completion.noCompletedStatus": null,
"contextMenus.task.completion.pickDateTitle": null,
"contextMenus.task.completion.completeFailure": null,
"contextMenus.task.completion.clearInstancesConfirmTitle": null,
"contextMenus.task.completion.clearInstancesConfirmMessage": null,
"contextMenus.task.completion.clearInstancesConfirmButton": null,
"contextMenus.task.quickReminders.atTime": {
"source": "87270e0d6c46f3d0c3510c6c2a2f1e31e8b0ab60",
"translation": "13edcc9c4ebe474df17518c264115a00ddf30433"
Expand Down Expand Up @@ -12114,6 +12132,8 @@
"source": "1673317e8fda5fc944e0458b5e51563c048e2dcd",
"translation": "7544b9bce2f306bf0f132f20496495986a8c0232"
},
"settings.appearance.taskCards.completionSubmenu.name": null,
"settings.appearance.taskCards.completionSubmenu.description": null,
"settings.appearance.taskCards.propertyGroups.coreProperties": {
"source": "acae0b9efe790c7be9c7a70dd1db4826a9eef7f7",
"translation": "a3fde73e81c95a92d5645faa11a31f43498671bf"
Expand Down Expand Up @@ -16234,6 +16254,22 @@
"source": "f58b99fdb842bddf12fa964f933eb1d9bd54843e",
"translation": "968673d261b5844d3efa0738be3c13af2077c0d9"
},
"contextMenus.task.completion.submenu": null,
"contextMenus.task.completion.submenuCompleteOnly": null,
"contextMenus.task.completion.completeToday": null,
"contextMenus.task.completion.completeAsScheduled": null,
"contextMenus.task.completion.completeOnDue": null,
"contextMenus.task.completion.completeOnPicked": null,
"contextMenus.task.completion.markIncomplete": null,
"contextMenus.task.completion.noScheduledDate": null,
"contextMenus.task.completion.noDueDate": null,
"contextMenus.task.completion.noPickedDate": null,
"contextMenus.task.completion.noCompletedStatus": null,
"contextMenus.task.completion.pickDateTitle": null,
"contextMenus.task.completion.completeFailure": null,
"contextMenus.task.completion.clearInstancesConfirmTitle": null,
"contextMenus.task.completion.clearInstancesConfirmMessage": null,
"contextMenus.task.completion.clearInstancesConfirmButton": null,
"contextMenus.task.quickReminders.atTime": {
"source": "87270e0d6c46f3d0c3510c6c2a2f1e31e8b0ab60",
"translation": "2838cecba7368421d90e0f07c0d0f1e28830ffa4"
Expand Down Expand Up @@ -20980,6 +21016,8 @@
"source": "1673317e8fda5fc944e0458b5e51563c048e2dcd",
"translation": "4e2b33fa3b0ae5c5bb3ad726108d1eb4b4da505f"
},
"settings.appearance.taskCards.completionSubmenu.name": null,
"settings.appearance.taskCards.completionSubmenu.description": null,
"settings.appearance.taskCards.propertyGroups.coreProperties": {
"source": "acae0b9efe790c7be9c7a70dd1db4826a9eef7f7",
"translation": "45c3c60132d0d7392905160e46d902e841ae8053"
Expand Down Expand Up @@ -25100,6 +25138,22 @@
"source": "f58b99fdb842bddf12fa964f933eb1d9bd54843e",
"translation": "dddefd2443584c9cf6331b468a73c21e6fe8556e"
},
"contextMenus.task.completion.submenu": null,
"contextMenus.task.completion.submenuCompleteOnly": null,
"contextMenus.task.completion.completeToday": null,
"contextMenus.task.completion.completeAsScheduled": null,
"contextMenus.task.completion.completeOnDue": null,
"contextMenus.task.completion.completeOnPicked": null,
"contextMenus.task.completion.markIncomplete": null,
"contextMenus.task.completion.noScheduledDate": null,
"contextMenus.task.completion.noDueDate": null,
"contextMenus.task.completion.noPickedDate": null,
"contextMenus.task.completion.noCompletedStatus": null,
"contextMenus.task.completion.pickDateTitle": null,
"contextMenus.task.completion.completeFailure": null,
"contextMenus.task.completion.clearInstancesConfirmTitle": null,
"contextMenus.task.completion.clearInstancesConfirmMessage": null,
"contextMenus.task.completion.clearInstancesConfirmButton": null,
"contextMenus.task.quickReminders.atTime": {
"source": "87270e0d6c46f3d0c3510c6c2a2f1e31e8b0ab60",
"translation": "c6fa1b8853d66e5ede8d309bb9f6d82dc4f10657"
Expand Down Expand Up @@ -29846,6 +29900,8 @@
"source": "1673317e8fda5fc944e0458b5e51563c048e2dcd",
"translation": "de48cc0c5751bfd7eb1c2a3f6043c0dcd7382581"
},
"settings.appearance.taskCards.completionSubmenu.name": null,
"settings.appearance.taskCards.completionSubmenu.description": null,
"settings.appearance.taskCards.propertyGroups.coreProperties": {
"source": "acae0b9efe790c7be9c7a70dd1db4826a9eef7f7",
"translation": "5547ff8f91ea1468c73df95fe41ba7ae215a21a1"
Expand Down Expand Up @@ -33966,6 +34022,22 @@
"source": "f58b99fdb842bddf12fa964f933eb1d9bd54843e",
"translation": "7cd7d70058059bb1602bce7e2c25a6edaf8ef029"
},
"contextMenus.task.completion.submenu": null,
"contextMenus.task.completion.submenuCompleteOnly": null,
"contextMenus.task.completion.completeToday": null,
"contextMenus.task.completion.completeAsScheduled": null,
"contextMenus.task.completion.completeOnDue": null,
"contextMenus.task.completion.completeOnPicked": null,
"contextMenus.task.completion.markIncomplete": null,
"contextMenus.task.completion.noScheduledDate": null,
"contextMenus.task.completion.noDueDate": null,
"contextMenus.task.completion.noPickedDate": null,
"contextMenus.task.completion.noCompletedStatus": null,
"contextMenus.task.completion.pickDateTitle": null,
"contextMenus.task.completion.completeFailure": null,
"contextMenus.task.completion.clearInstancesConfirmTitle": null,
"contextMenus.task.completion.clearInstancesConfirmMessage": null,
"contextMenus.task.completion.clearInstancesConfirmButton": null,
"contextMenus.task.quickReminders.atTime": {
"source": "87270e0d6c46f3d0c3510c6c2a2f1e31e8b0ab60",
"translation": "7fdead3a6d8aaccda120699da7e45e369edc108c"
Expand Down Expand Up @@ -38712,6 +38784,8 @@
"source": "1673317e8fda5fc944e0458b5e51563c048e2dcd",
"translation": "8c6ff390fde8a9506470b23ec2db414c267a6909"
},
"settings.appearance.taskCards.completionSubmenu.name": null,
"settings.appearance.taskCards.completionSubmenu.description": null,
"settings.appearance.taskCards.propertyGroups.coreProperties": {
"source": "acae0b9efe790c7be9c7a70dd1db4826a9eef7f7",
"translation": "cc315ebd9ef6c843c3663a2a97dba8eda9edb868"
Expand Down Expand Up @@ -42832,6 +42906,22 @@
"source": "f58b99fdb842bddf12fa964f933eb1d9bd54843e",
"translation": "eff53181b011d57fdf7dfb4617f7807573a53d23"
},
"contextMenus.task.completion.submenu": null,
"contextMenus.task.completion.submenuCompleteOnly": null,
"contextMenus.task.completion.completeToday": null,
"contextMenus.task.completion.completeAsScheduled": null,
"contextMenus.task.completion.completeOnDue": null,
"contextMenus.task.completion.completeOnPicked": null,
"contextMenus.task.completion.markIncomplete": null,
"contextMenus.task.completion.noScheduledDate": null,
"contextMenus.task.completion.noDueDate": null,
"contextMenus.task.completion.noPickedDate": null,
"contextMenus.task.completion.noCompletedStatus": null,
"contextMenus.task.completion.pickDateTitle": null,
"contextMenus.task.completion.completeFailure": null,
"contextMenus.task.completion.clearInstancesConfirmTitle": null,
"contextMenus.task.completion.clearInstancesConfirmMessage": null,
"contextMenus.task.completion.clearInstancesConfirmButton": null,
"contextMenus.task.quickReminders.atTime": {
"source": "87270e0d6c46f3d0c3510c6c2a2f1e31e8b0ab60",
"translation": "ee19ba1d573cbe4fb6cbbab4cb59e86260dd132a"
Expand Down Expand Up @@ -47578,6 +47668,8 @@
"source": "1673317e8fda5fc944e0458b5e51563c048e2dcd",
"translation": "4a1cd9917a4b43ae471d4c2a299469db22cd0210"
},
"settings.appearance.taskCards.completionSubmenu.name": null,
"settings.appearance.taskCards.completionSubmenu.description": null,
"settings.appearance.taskCards.propertyGroups.coreProperties": {
"source": "acae0b9efe790c7be9c7a70dd1db4826a9eef7f7",
"translation": "8a083e47d10d9cb24fbe3039f3247ffb08f7f97c"
Expand Down Expand Up @@ -51698,6 +51790,22 @@
"source": "f58b99fdb842bddf12fa964f933eb1d9bd54843e",
"translation": "5c886f6f62aeb8f203759a44e10a075079e1555e"
},
"contextMenus.task.completion.submenu": null,
"contextMenus.task.completion.submenuCompleteOnly": null,
"contextMenus.task.completion.completeToday": null,
"contextMenus.task.completion.completeAsScheduled": null,
"contextMenus.task.completion.completeOnDue": null,
"contextMenus.task.completion.completeOnPicked": null,
"contextMenus.task.completion.markIncomplete": null,
"contextMenus.task.completion.noScheduledDate": null,
"contextMenus.task.completion.noDueDate": null,
"contextMenus.task.completion.noPickedDate": null,
"contextMenus.task.completion.noCompletedStatus": null,
"contextMenus.task.completion.pickDateTitle": null,
"contextMenus.task.completion.completeFailure": null,
"contextMenus.task.completion.clearInstancesConfirmTitle": null,
"contextMenus.task.completion.clearInstancesConfirmMessage": null,
"contextMenus.task.completion.clearInstancesConfirmButton": null,
"contextMenus.task.quickReminders.atTime": {
"source": "87270e0d6c46f3d0c3510c6c2a2f1e31e8b0ab60",
"translation": "a2936a5b99f3ba9aef0ef806a85097d30db91392"
Expand Down Expand Up @@ -56444,6 +56552,8 @@
"source": "1673317e8fda5fc944e0458b5e51563c048e2dcd",
"translation": "046d0996624d117cbbafac2278b6c7a1bf2d99c3"
},
"settings.appearance.taskCards.completionSubmenu.name": null,
"settings.appearance.taskCards.completionSubmenu.description": null,
"settings.appearance.taskCards.propertyGroups.coreProperties": {
"source": "acae0b9efe790c7be9c7a70dd1db4826a9eef7f7",
"translation": "273a4585152f46d25617f5b68785c0aaa5ad0743"
Expand Down Expand Up @@ -60564,6 +60674,22 @@
"source": "f58b99fdb842bddf12fa964f933eb1d9bd54843e",
"translation": "4b21cae430620be61f61dc2db0e6dc1ed867b28d"
},
"contextMenus.task.completion.submenu": null,
"contextMenus.task.completion.submenuCompleteOnly": null,
"contextMenus.task.completion.completeToday": null,
"contextMenus.task.completion.completeAsScheduled": null,
"contextMenus.task.completion.completeOnDue": null,
"contextMenus.task.completion.completeOnPicked": null,
"contextMenus.task.completion.markIncomplete": null,
"contextMenus.task.completion.noScheduledDate": null,
"contextMenus.task.completion.noDueDate": null,
"contextMenus.task.completion.noPickedDate": null,
"contextMenus.task.completion.noCompletedStatus": null,
"contextMenus.task.completion.pickDateTitle": null,
"contextMenus.task.completion.completeFailure": null,
"contextMenus.task.completion.clearInstancesConfirmTitle": null,
"contextMenus.task.completion.clearInstancesConfirmMessage": null,
"contextMenus.task.completion.clearInstancesConfirmButton": null,
"contextMenus.task.quickReminders.atTime": {
"source": "87270e0d6c46f3d0c3510c6c2a2f1e31e8b0ab60",
"translation": "0a461c2b22896eac59c259415fdbbe96b207b9bc"
Expand Down Expand Up @@ -65310,6 +65436,8 @@
"source": "1673317e8fda5fc944e0458b5e51563c048e2dcd",
"translation": "b0935ca50aeb4136e0ed0229514b3e25e05bb98f"
},
"settings.appearance.taskCards.completionSubmenu.name": null,
"settings.appearance.taskCards.completionSubmenu.description": null,
"settings.appearance.taskCards.propertyGroups.coreProperties": {
"source": "acae0b9efe790c7be9c7a70dd1db4826a9eef7f7",
"translation": "6503db48028c919fb82aa2f1b6beb676980bc93e"
Expand Down Expand Up @@ -69430,6 +69558,22 @@
"source": "f58b99fdb842bddf12fa964f933eb1d9bd54843e",
"translation": "5d08dfcf44803b1604301a2e36d0eb317fa81ca2"
},
"contextMenus.task.completion.submenu": null,
"contextMenus.task.completion.submenuCompleteOnly": null,
"contextMenus.task.completion.completeToday": null,
"contextMenus.task.completion.completeAsScheduled": null,
"contextMenus.task.completion.completeOnDue": null,
"contextMenus.task.completion.completeOnPicked": null,
"contextMenus.task.completion.markIncomplete": null,
"contextMenus.task.completion.noScheduledDate": null,
"contextMenus.task.completion.noDueDate": null,
"contextMenus.task.completion.noPickedDate": null,
"contextMenus.task.completion.noCompletedStatus": null,
"contextMenus.task.completion.pickDateTitle": null,
"contextMenus.task.completion.completeFailure": null,
"contextMenus.task.completion.clearInstancesConfirmTitle": null,
"contextMenus.task.completion.clearInstancesConfirmMessage": null,
"contextMenus.task.completion.clearInstancesConfirmButton": null,
"contextMenus.task.quickReminders.atTime": {
"source": "87270e0d6c46f3d0c3510c6c2a2f1e31e8b0ab60",
"translation": "7aaeb02feb12bd8334344d70a17e16b367174054"
Expand Down
7 changes: 7 additions & 0 deletions jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
// Pin the test timezone to UTC so local runs match CI (GitHub Actions runs in
// UTC). Set here — before Jest spawns its worker processes — so each worker
// inherits TZ and reads it at startup, before any Date is constructed (V8 caches
// the zone on first use). Overridable with an explicit `TZ=... jest` for
// timezone-specific testing.
process.env.TZ = process.env.TZ || 'UTC';

module.exports = {
preset: 'ts-jest',
testEnvironment: 'jsdom',
Expand Down
5 changes: 5 additions & 0 deletions jest.integration.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
// Pin the test timezone to UTC so local runs match CI (GitHub Actions runs in
// UTC). See jest.config.js for the rationale (set before workers spawn so each
// inherits TZ before any Date is constructed). Overridable via `TZ=... jest`.
process.env.TZ = process.env.TZ || 'UTC';

module.exports = {
preset: 'ts-jest',
testEnvironment: 'jsdom',
Expand Down
Loading