fix(rbac): make updateRole atomic via dataSource.transaction (#1050)#1079
Open
Chrisland58 wants to merge 1 commit into
Open
fix(rbac): make updateRole atomic via dataSource.transaction (#1050)#1079Chrisland58 wants to merge 1 commit into
Chrisland58 wants to merge 1 commit into
Conversation
…de#1050) - Inject DataSource into RolesService - Wrap updateRole in dataSource.transaction() so name update and permission reassignment commit or roll back together - Acquire PESSIMISTIC_WRITE row lock at the start of the transaction so concurrent updates to the same role serialize - Throw NotFoundException inside the transaction (before any writes) when the role does not exist - Move audit log writes to after the transaction commits so they are never recorded for rolled-back mutations - Add four new unit tests (Issue rinafcode#1050): * rolls back name change when permission set throws * no audit written on NotFoundException inside tx * single dataSource.transaction call wraps all writes * audit written only after transaction commits Closes rinafcode#1050
|
@Chrisland58 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Well done on the job done so far! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1050