fix: add missing access token JTI claim and blacklist check (#878) - #1093
Merged
Conversation
|
@fahatadam Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
fix: add missing access token JTI claim and blacklist check
Description
What was done:
auth.service.tsto include a uniquejti(usingrandomUUIDfrom the nativecryptomodule) in the payload of every generated access token.JwtPayloadinterface to strongly type the newjtiproperty.TokenBlacklistServiceinto theJwtStrategy.JwtStrategy.validate()method to check the extractedjtiagainst the token blacklist on every incoming request, throwing anUnauthorizedExceptionif the token was found to be revoked.jwt.strategy.spec.tsmocking the blacklist validation flow to confirm requests with revokedjtis are properly rejected.Why it was done:
Previously, access tokens only contained
{sub, email, role}, preventing the targeted revocation of individual tokens. Without ajti(JWT ID), blacklisting required revoking all tokens for a given user. Introducing thejtienables a coarse-grained revocation strategy and solves targeted logout capabilities (e.g. logging out a specific device) to prevent replay attacks after a blacklist bypass.How it was verified:
jtiinclusion alongside the normal payload upon token generation.UnauthorizedExceptionis thrown when a matching blacklistedjtimakes an authenticated request.Closes #878