Fix/prettier cost formatting - #1094
Merged
RUKAYAT-CODER merged 2 commits intoJul 26, 2026
Merged
Conversation
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains two formatting-only fixes required by Prettier/ESLint that currently block CI:
Make the expect(...).toHaveBeenCalledWith(...) arguments multiline (prettier formatting) in src/monitoring/cost-scheduler.service.spec.ts
Expand an inline ternary used for metric labels into a multi-line object in src/monitoring/cost-tracking.service.ts
Why
The CI job fails on the lint step with prettier/prettier errors (auto-fixable). These changes align the code with the project's prettier rules so the lint step no longer fails and the rest of the pipeline can run.
Files changed
src/monitoring/cost-scheduler.service.spec.ts
Replace single-line expect call with a multiline call: expect(costService.recordHourlyCost).toHaveBeenCalledWith( result.amount, result.billingPeriod, );
src/monitoring/cost-tracking.service.ts
Replace the one-line ternary: const labels = billingPeriod ? { billing_period: billingPeriod } : { billing_period: 'unknown' };
With a multi-line form: const labels = billingPeriod ? { billing_period: billingPeriod, } : { billing_period: 'unknown', };
Testing steps (what I ran / what you should run)
pnpm install
pnpm run lint # eslint --fix will auto-fix many issues
pnpm run lint:ci # run CI lint check
pnpm run typecheck
pnpm run build
pnpm test --testPathPattern="monitoring"
Acceptance checklist
Lint (prettier) no longer fails on changed files
Typecheck passes
Build passes
Related tests pass locally
closes #1037