fix: enforce tenant isolation on all SearchService Elasticsearch queries (#889)#1096
Merged
RUKAYAT-CODER merged 1 commit intoJul 27, 2026
Conversation
|
@extolkom Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enforces tenant isolation on all Elasticsearch queries constructed by SearchService to resolve potential cross-tenant data leaks.
Closes #889
Changes
Dependency Injection: Injected IsolationService into
SearchService
and imported TenancyModule in
SearchModule
.
Tenant Filter Helper: Added buildTenantFilter(tenantId: string) helper returning { term: { tenantId } }.
Query Filter Enforcement: Updated tryElasticsearch to wrap search queries in a bool query containing filter: [this.buildTenantFilter(tenantId)] for both keyword searches (multi_match) and empty/browse searches (match_all).
Tests: Added integration tests in
search.service.spec.ts
covering:
tenant_a_search_excludes_tenant_b_content
tenant_filter_applied_with_empty_query
tenant_filter_applied_across_all_query_methods