Skip to content

Feat/logging - #904

Merged
RUKAYAT-CODER merged 4 commits into
rinafcode:mainfrom
ahmadogo:feat/logging
Jul 29, 2026
Merged

Feat/logging#904
RUKAYAT-CODER merged 4 commits into
rinafcode:mainfrom
ahmadogo:feat/logging

Conversation

@ahmadogo

Copy link
Copy Markdown
Contributor

Summary

This PR addresses several bugs related to font loading, session management, logging, and offline behavior.

Summary of Changes:

  • Robust Font Loading: Merged primary and secondary font loading into a single, cancellable operation at startup. Failures are now caught and reported to Sentry instead of failing silently.

  • Bounded Refresh Queue: Capped the token refresh request queue at 50 requests and ensured it is cleared on logout to prevent unbounded growth and stale requests between sessions.

  • Refined Production Logging: Adjusted the production logging override to only silence console.log, while preserving console.warn and console.error for better diagnostics in crash reporting tools. An ESLint rule has been updated to enforce this.

  • Offline Logout Reliability: The logout process now queues the server-side session invalidation request if the device is offline, ensuring the request is sent when connectivity is restored. Local tokens are cleared immediately regardless.

Closes #765
Closes #766
Closes #767
Closes #768

Testing Done

  • Unit Tests
  • Integration Tests
  • Manual Verification (e.g., iOS/Android UI checks)

Security Considerations

  • Does this store user data securely (e.g., avoiding plain AsyncStorage for sensitive data)?
  • Is token handling secure (no token exposure in logs or UI)?
  • Are all user inputs validated?
  • Is deep link handling safe from malicious payloads?

Performance Considerations

  • Are React hooks (useCallback, useMemo) used appropriately to prevent unnecessary renders?
  • Is FlatList optimized (e.g., using getItemLayout, keyExtractor)?
  • Are asynchronous patterns handled correctly (e.g., useEffect cleanup to avoid memory leaks)?
  • Have bundle size impacts been considered?

Checklist

  • I have read the CONTRIBUTING guide.
  • My code follows the style guidelines of this project.
  • I have updated the documentation accordingly.
  • Are there architectural changes? If so, is there an Architectural Decision Record (ADR)?

@drips-wave

drips-wave Bot commented Jul 29, 2026

Copy link
Copy Markdown

@ahmadogo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@RUKAYAT-CODER

Copy link
Copy Markdown
Contributor

Thank you for contributing to the project

@RUKAYAT-CODER
RUKAYAT-CODER merged commit b84fcbd into rinafcode:main Jul 29, 2026
1 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment