Feat/logging - #904
Merged
Merged
Conversation
…ever cleared between sessions
…put in production including errors
…on never invalidated
|
@ahmadogo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses several bugs related to font loading, session management, logging, and offline behavior.
Summary of Changes:
Robust Font Loading: Merged primary and secondary font loading into a single, cancellable operation at startup. Failures are now caught and reported to Sentry instead of failing silently.
Bounded Refresh Queue: Capped the token refresh request queue at 50 requests and ensured it is cleared on logout to prevent unbounded growth and stale requests between sessions.
Refined Production Logging: Adjusted the production logging override to only silence console.log, while preserving console.warn and console.error for better diagnostics in crash reporting tools. An ESLint rule has been updated to enforce this.
Offline Logout Reliability: The logout process now queues the server-side session invalidation request if the device is offline, ensuring the request is sent when connectivity is restored. Local tokens are cleared immediately regardless.
Closes #765
Closes #766
Closes #767
Closes #768
Testing Done
Security Considerations
Performance Considerations
useCallback,useMemo) used appropriately to prevent unnecessary renders?FlatListoptimized (e.g., usinggetItemLayout,keyExtractor)?useEffectcleanup to avoid memory leaks)?Checklist