fix: validate biometric type at runtime to prevent spoofing - #908
Merged
RUKAYAT-CODER merged 1 commit intoJul 30, 2026
Merged
Conversation
|
@collinsezedike Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
Checked the failing CI jobs on this PR. All of them trace back to issues that already exist on main and are unrelated to this change:
Keeping this PR scoped to the biometric type validation described in issue #782 rather than bundling in unrelated repo-wide fixes. Happy to address the lockfile/TS debt separately if maintainers want it split out. |
Contributor
|
Thank you for contributing to the project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a runtime type guard for
BiometricTypevalues so that a value returned from an abstract/mocked authentication method cannot bypass the compile-time type and be used as-is.getSupportedBiometricTypenow validates its resolved value againstVALID_BIOMETRIC_TYPESbefore returning it, closing the gap where mocked or test environments could spoof an arbitrary string as a valid biometric type.Type of Change
Testing Done
Added tests covering
isValidBiometricTypefor all valid biometric types, invalid strings (including near-miss casing/whitespace), and non-string values (null, undefined, number, boolean, object, array, symbol).Security Considerations
The biometric type returned from the native/abstract authentication layer is now validated at runtime via
isValidBiometricTypebefore use, preventing spoofed values in mocked or test environments.Performance Considerations
N/A - no rendering or list changes.
Checklist
Closes #782