fix(audio): add error state and handle autoplay re-init on src change#1003
Merged
RUKAYAT-CODER merged 1 commit intoJul 27, 2026
Merged
Conversation
|
@dominiccreates Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #974
This PR addresses an issue in AudioPlayer where a failed media source would leave the component in an infinite loading state. It also resolves autoplay re-initialization on source change.
Changes:
Added Error State Handling: Introduced a hasError state and an error event listener on the HTMLAudioElement.
Error UI: If the audio fails to load, the infinite spinner is replaced by a visually consistent error overlay ("Failed to load audio") using framer-motion.
State Reset: Both isLoading and hasError states properly reset whenever the src prop changes.
Autoplay Re-initialization: Explicitly called audioRef.current.load() before audioRef.current.play() when autoPlay is true. This ensures the media element properly resets and attempts playback when the src changes.