Skip to content

Memoize groupActivitiesByDate in the social ActivityFeed#1005

Closed
jaynomyaro wants to merge 0 commit into
rinafcode:mainfrom
jaynomyaro:jay
Closed

Memoize groupActivitiesByDate in the social ActivityFeed#1005
jaynomyaro wants to merge 0 commit into
rinafcode:mainfrom
jaynomyaro:jay

Conversation

@jaynomyaro

Copy link
Copy Markdown

Description
This PR introduces memoization for the groupActivitiesByDate function used in the Social ActivityFeed component. By caching results based on input dependencies, we reduce redundant computations and improve rendering performance, especially when the feed contains a large number of activities.

Key Changes
Wrapped groupActivitiesByDate with useMemo to avoid recalculations when inputs remain unchanged.

Ensured dependency array includes only relevant props/state to prevent stale data.

Added unit tests to confirm memoization behavior and correctness of grouped results.

Verified that UI updates correctly when new activities are added or existing ones change.

Motivation
The ActivityFeed often re-renders due to state changes, causing groupActivitiesByDate to run multiple times unnecessarily. Memoization improves efficiency and responsiveness, leading to a smoother user experience.

Testing
Confirmed that repeated renders with identical activity lists do not trigger recomputation.

Verified that changes in activities correctly invalidate the memoized result.

Benchmarked rendering performance before and after memoization.

Checklist
[x] Memoization implemented

[x] Dependencies correctly set

[x] Tests updated and passing

[x] Performance validated
Closed #977

@drips-wave

drips-wave Bot commented Jul 26, 2026

Copy link
Copy Markdown

@jaynomyaro Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Memoize groupActivitiesByDate in the social ActivityFeed

1 participant