Memoize groupActivitiesByDate in the social ActivityFeed#1005
Closed
jaynomyaro wants to merge 0 commit into
Closed
Memoize groupActivitiesByDate in the social ActivityFeed#1005jaynomyaro wants to merge 0 commit into
jaynomyaro wants to merge 0 commit into
Conversation
|
@jaynomyaro Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces memoization for the groupActivitiesByDate function used in the Social ActivityFeed component. By caching results based on input dependencies, we reduce redundant computations and improve rendering performance, especially when the feed contains a large number of activities.
Key Changes
Wrapped groupActivitiesByDate with useMemo to avoid recalculations when inputs remain unchanged.
Ensured dependency array includes only relevant props/state to prevent stale data.
Added unit tests to confirm memoization behavior and correctness of grouped results.
Verified that UI updates correctly when new activities are added or existing ones change.
Motivation
The ActivityFeed often re-renders due to state changes, causing groupActivitiesByDate to run multiple times unnecessarily. Memoization improves efficiency and responsiveness, leading to a smoother user experience.
Testing
Confirmed that repeated renders with identical activity lists do not trigger recomputation.
Verified that changes in activities correctly invalidate the memoized result.
Benchmarked rendering performance before and after memoization.
Checklist
[x] Memoization implemented
[x] Dependencies correctly set
[x] Tests updated and passing
[x] Performance validated
Closed #977