Skip to content

🐛 RelationConnection loads the same relation twice under AsyncDataloader (2.6.7) #5685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benschwarz wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −2
Open

🐛 RelationConnection loads the same relation twice under AsyncDataloader (2.6.7) #5685

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions lib/graphql/pagination/relation_connection.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,19 @@ def limited_nodes
# Load nodes after applying first/last/before/after,
# returns an array of nodes
def load_nodes
# Return an array so we can consistently use `.index(node)` on it
@nodes ||= limited_nodes.to_a
return @nodes if @nodes

if @loading_nodes
context.dataloader.yield until @nodes
return @nodes
end

@loading_nodes = true
begin
@nodes = limited_nodes.to_a
ensure
@loading_nodes = false
end
end
end
end
Expand Down
Loading