fix(cli): sanitize inherited Pi package directory - #120
Merged
rochecompaan merged 2 commits intoJul 28, 2026
Merged
Conversation
rochecompaan
deleted the
agent/issue-117-patchmill-inherits-outer-pi-pi-package-dir-and-b
branch
July 28, 2026 19:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PI_PACKAGE_DIRbefore loading the bundled CLI graph.Validation
node --test bin/patchmill.test.tspassed (2/2)npm testpassed (1122 tests, 0 failures)npm run lintpassednpm run buildpassed (emission check; TypeScript build hasnoCheckenabled)node dist/bin/patchmill.js --helppassedPI_PACKAGE_DIR=/nix/store/outer-pi/libexec/pi "$package_path/bin/patchmill" --helppassed afternix build .#patchmill --no-link --print-out-pathsgit diff --checkpassed; worktree cleanReviews
Closes #117
Patchmill run cost
Prompt tokens include uncached input, cache reads, and cache writes. Cost is an estimate based on Pi's recorded model pricing and includes parent and subagent sessions.