Fix Synology docker-compose example (issue #98)#101
Merged
Conversation
The compose snippet include on the Synology install page was commented out and never rendered. Uncomment it and match the working truenas / quick-start include pattern. Also drop `start_interval` from the Synology healthcheck. Synology's Container Manager ships an older Docker Compose that rejects it, which matches the "simplified healthcheck" the page already advertises. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #98
Problem
Two issues reported by a user following the Synology install guide:
The docker-compose example didn't render. The snippet include on
docs/install/synology.mdwas commented out and had been dead since the file's first commit, so the page showed an empty example admonition.start_intervalbreaks validation on Synology. The user hitservices.romm-db.healthcheck Additional property start_interval is not allowed. Synology's Container Manager ships an older Docker Compose that doesn't supportstart_interval.Changes
truenas.md/quick-start.mdpattern (verified byte-identical totruenas.md). The example now renders.start_interval: 10sfrom the Synology healthcheck. This aligns with the "simplified healthcheck" the page already advertises, and the healthcheck still works usinginterval.🤖 Generated with Claude Code