Support choices lists for YAML launch arguments#986
Open
Old-Ding wants to merge 1 commit into
Open
Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
Map the YAML-specific choices shorthand to existing choice entities so list syntax matches Python launch files while preserving the legacy form. Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
a9cecf5 to
9fa6db8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
YAML launch arguments currently support choices only through the XML-shaped form:
Allow the natural YAML shorthand
choices: [ur3, ur5e]. The YAML entity adapter validates the shorthand as a string list and maps it to the samechoice/valueentities already consumed byDeclareLaunchArgument.parse(). The existing syntax and common launch layer remain unchanged; providing both forms is still rejected by the existing unparsed-key validation.Fixes #698.
Is this user-facing behavior change?
Yes. YAML launch files can now declare argument choices with a scalar list matching the Python API's
choicesspelling.Did you use Generative AI?
Yes. OpenAI Codex assisted with root-cause analysis and preparing the focused code and regression test. I reviewed the diff and verification results.
Additional Information
Local verification:
launch_yamlfunctional tests passedament_flake8,ament_pep257, andament_copyrightpassed for all 22 checked filescompileallandgit diff --checkpassedament_mypyreports the same 16 pre-existingEntity/Parserannotation errors on both the clean baseline and this branch, with no new diagnostics