Skip to content

Materialize TimerAction action iterables#987

Open
Old-Ding wants to merge 1 commit into
ros2:rollingfrom
Old-Ding:codex/materialize-timer-actions
Open

Materialize TimerAction action iterables#987
Old-Ding wants to merge 1 commit into
ros2:rollingfrom
Old-Ding:codex/materialize-timer-actions

Conversation

@Old-Ding

@Old-Ding Old-Ding commented Jul 11, 2026

Copy link
Copy Markdown

Summary

  • materialize TimerAction.actions once at construction
  • prevent introspection from consuming one-shot iterables before the timer fires
  • cover repeated access after describing conditional sub-entities

Testing

  • focused source behavior probe: baseline retains no actions after introspection, while the fixed implementation retains them
  • launch/test/launch/test_timer_action.py: 7 passed
  • ament_flake8, ament_pep257, and ament_copyright on both modified files
  • python -m py_compile on both modified files
  • git diff --check

TimerAction accepts an Iterable of actions but exposes and traverses it during both introspection and timer handling. Store a list so inspecting a one-shot iterator cannot consume the actions before the timer fires.

Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
@mergify

mergify Bot commented Jul 11, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant