Allow empty YAML entity lists#992
Open
Old-Ding wants to merge 1 commit into
Open
Conversation
Treat explicitly empty nested entity lists as valid input instead of indexing the missing first element. This lets generated YAML retain empty include argument lists without raising IndexError. Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
launch_yaml.Entity.get_attr()indexed the first item of every nested entity list while validating its shape. Explicitly empty lists such asarg: []orlet: []therefore raisedIndexErrorinstead of being parsed as empty child collections.Accept empty nested entity lists at the YAML adapter boundary and retain the existing dictionary check for non-empty lists. Add an include-action regression covering both empty argument forms.
Is this user-facing behavior change?
Yes. YAML launch files can now contain explicitly empty nested entity lists without failing during parsing.
Did you use Generative AI?
Yes. OpenAI Codex assisted with tracing the YAML parser data flow, preparing the focused fix and regression test, and reviewing the result. I reviewed the diff and verification output.
Additional Information
Local verification:
IndexErrorwith an emptyList[Entity]attributelaunch_yamlfunctional tests passedament_flake8,ament_pep257, andament_copyrightpassed for both changed filesgit diff --checkpassed