perf(vision): fuse bilinear resize to grayscale - #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resize_rgb_to_gray_image(..., out=...)in Python with synchronized stubs and testsResults
On the recorded 12-thread Windows host, the allocated 1920x1080 to 960x540 pipeline measured 0.677 ms versus OpenCV's two-call 0.755 ms, a 1.12x SpatialRust win. Native caller-owned fused execution improves over SpatialRust's unfused path by 1.09x at 1080p, 1.15x at 4K, and 1.17x at 8K.
The claim is scoped: 4K allocated is effectively tied, while OpenCV leads 8K allocation and all caller-owned-output comparisons.
Fused output is bit-exact with the SpatialRust unfused plan. Canonical and 300 randomized OpenCV comparisons have maximum absolute error 1/255.
Validation
cargo test -p spatialrust-vision --features fullcargo clippy -p spatialrust-vision --features preprocess --all-targets -- -D warnings