Add allocation-light Canny path - #47
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
canny()avoid public intermediate imagescanny_intoand reusableCannyWorkspaceout=/ workspace support and a focused OpenCV harnessWhy
The previous implementation always materialized gradients, magnitude, and suppression images even when callers only requested the final edge map. That allocation and conversion overhead made the published OpenCV comparison stale after the newer reusable CPU work.
Impact
The focused OpenCV 4.13 receipt is bit-exact across 300 randomized cases. The standalone OpenCV lead is reduced from the superseded 10.66×–12.65× table row to 1.65×–1.77× on reusable document-line profiles. OpenCV still leads, and Epic 118D remains open.
Validation
cargo test -p spatialrust-vision --features imgproc-canny(25 passed)cargo clippy -p spatialrust-vision --features imgproc-canny -- -D warningscargo check --manifest-path crates/spatialrust-py/Cargo.toml