Add Canny magnitude ring - #48
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The remaining full
i32magnitude image consumed 31.6 MiB at 4K and added avoidable memory traffic. High-contrast inputs also paid for graph traversal even when every retained edge was already strong.Impact
The fast path stays bit-exact with OpenCV across 300 randomized cases. Native 4K document lines improve from 96.914 ms with inspectable intermediates to 8.134 ms with ring reuse (11.92×). Python reuse measures 8.103 ms versus OpenCV 11.480 ms (SpatialRust 1.42×); 1080p is 1.36× faster. Dense sensor noise remains an OpenCV win and is documented as such.
Validation
cargo test -p spatialrust-vision --features imgproc-canny(26 passed)-D warnings