build(deps): bump @rollup/plugin-typescript to 12.3.0 - #661
Open
ledsun wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@rollup/plugin-typescriptfrom 12.1.4 to 12.3.0outDirexplicitly to keep generated files underdist@rollup/plugin-typescriptblocker before build(deps): bump the dependencies group across 1 directory with 11 updates #614 can proceedBackground
Version 12.3.0 creates a temporary TypeScript
outDirwhenallowJsis enabled. Its path validation then rejects that temporary directory because the Rollupfileoutputs are underdist. Explicitly setting the plugin'soutDirto./distkeeps the output paths compatible.Verification
bundle exec rake npm:ruby-wasm-wasi:buildThe Rollup UMD outputs and the subsequent ESM/CJS TypeScript builds complete successfully.