Skip the make job server when using BSD make#9676
Open
flavorjones wants to merge 1 commit into
Open
Conversation
Like nmake, BSD make can't parse the GNU `--jobserver-auth` flag in
MAKEFLAGS and aborts native extension builds with:
make: argument 'observer-auth=6,7' to option '-j' must be a positive number
Skip the jobserver on BSD platforms, unless an gmake is explicitly
being used.
Collaborator
Author
|
If merged, this should be backported to the release branch because 4.0.15 contains the jobserver feature. |
flavorjones
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Like nmake (#9630), BSD make can't parse the GNU
--jobserver-authflag in MAKEFLAGS and aborts native extension builds with:What is your fix for the problem, implemented in this PR?
Skip the jobserver on BSD platforms, unless gmake is explicitly being used. Similar in approach to #9630 for nmake.
Make sure the following tasks are checked