Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

### Fixed
- Ensure node has focus before setting value [#280]
- `Capybara::Cuprite::Node#send_keys` ignores empty or nil keys instead of raising, matching the Selenium and rack_test drivers

### Removed

Expand Down
3 changes: 3 additions & 0 deletions lib/capybara/cuprite/node.rb
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,9 @@ def ==(other)
end

def send_keys(*keys)
keys = keys.reject { |key| key.nil? || key == "" }
return if keys.empty?

command(:send_keys, keys)
end
alias send_key send_keys
Expand Down
9 changes: 9 additions & 0 deletions spec/features/driver_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -1272,6 +1272,15 @@ def create_screenshot(file, *args)
expect(input.value).to eq("Text appended")
end

it "ignores empty or nil keys instead of raising" do
input = @session.find(:css, "#filled_input")

expect { input.native.send_keys("") }.not_to raise_error
expect { input.native.send_keys(nil) }.not_to raise_error

expect(input.value).to eq("Text")
end

it "sends keys to empty textarea" do
input = @session.find(:css, "#empty_textarea")

Expand Down
Loading